Skip to content

Disable loading code style analyzers when building from VS #48522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Disable loading code style analyzers when building from VS #48522

wants to merge 2 commits into from

Conversation

tmat
Copy link
Member

@tmat tmat commented Apr 16, 2025

Allows using Visual Studio from dogfood environment while Roslyn version is higher than what's available in the latest VS msbuild.

Fixes VS-only build issues like

Analyzer assembly 'C:\sdk5\artifacts\bin\redist\Debug\dotnet\sdk\10.0.100-dev\Sdks\Microsoft.NET.Sdk\codestyle\cs\Microsoft.CodeAnalysis.CodeStyle.dll' cannot be used because it references version '...' of the compiler, which is newer than the currently running version '...'.

@Copilot Copilot AI review requested due to automatic review settings April 16, 2025 17:32
Copilot
Copilot AI reviewed Apr 16, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (2)
  • Directory.Build.props: Language not supported
  • Directory.Build.targets: Language not supported

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Apr 16, 2025
@tmat tmat force-pushed the RemoveCodeStyle branch from 3d6f4c2 to 1ec5e84 Compare April 16, 2025 17:37
@jaredpar
Copy link
Member

dotnet/roslyn#78200

That PR should relieve the pressure here.

jaredpar
jaredpar requested changes Apr 19, 2025
View reviewed changes
Copy link
Member

@jaredpar jaredpar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to chat before we merge this in. None of us can hit this problem locally in our VS. Want to make sure we understand this before we merge in the work around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@jaredpar jaredpar jaredpar requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmat @jaredpar